✅ Use proper is_active field in test_user.py#1479
Merged
tiangolo merged 2 commits intofastapi:masterfrom Jan 22, 2026
Merged
Conversation
alejsdev
changed the title
YuriiMotov
changed the title
is_active field in test_user.py
YuriiMotov
approved these changes
Sep 2, 2025
Member
YuriiMotov
left a comment
YuriiMotov
left a comment
There was a problem hiding this comment.
LGTM
Previously UserCreate used default value for is_active (True) and test didn't fail because assertion was wrong.
@nauanbek, thanks!
YuriiMotov
changed the title
is_active field in test_user.pyis_active field in test_user.py
alejsdev
approved these changes
Sep 7, 2025
Contributor
|
This pull request has a merge conflict that needs to be resolved. |
github-actions
bot
added
the
conflicts
…t-parameter-test-user
github-actions
bot
removed
the
conflicts
samsam926
pushed a commit
to samsam926/KD-Path
that referenced
this pull request
Jan 28, 2026
Co-authored-by: Yurii Motov <yurii.motov.monte@gmail.com>
This was referenced Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEFORE: user_in = UserCreate(email=email, password=password, disabled=True)
AFTER: Use proper is_active field
Discussion: #1407